Add ConditionTrait.evaluate() #909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm trying to decide what tests to add. Are existing tests enough, since I pretty much just moved existing logic to a different place? |
|
We aim for 100% code coverage when testing, so the new function should be tested (even if it is just a trivial "did this return true when I expected it to?" test.) |
grynspan
reviewed
Jan 14, 2025
grynspan
added
enhancement
grynspan
reviewed
Jan 14, 2025
grynspan
reviewed
Jan 14, 2025
grynspan
reviewed
Jan 14, 2025
|
I plan to add some tests soon, at which point I think it will be appropriate to take the PR out of draft mode. |
Uncommon
requested review from
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
Uncommon
force-pushed
the
evaluateCondition
branch
from
2c6c863 to
979f23f
Compare
There was a problem hiding this comment.
Thanks @Uncommon! Just a couple more comments but this looks close to landing. We can land this before the associated Swift evolution proposal review begins (assuming it moves forward), since the additions are @_spi.
stmontgomery
requested changes
Mar 28, 2025
stmontgomery
approved these changes
Mar 28, 2025
|
@swift-ci please test |
|
Fixes #903 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ConditionTrait.evaluate()so that a condition can be evaluated independent of aTestobject.Motivation:
Currently, the only way a
ConditionTraitis evaluated is inside theprepare(for:)method. This makes it difficult and awkward for third-party libraries to utilize these traits because evaluating a condition would require creating a dummyTestto pass to that method.Modifications:
Add
ConditionTrait.evaluate(), andConditionTrait.Evaluationenum for the return value.Result:
Public API allows for evaluating a
ConditionTraitin any context.Checklist: